Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented Sep 14, 2016

Linking the files from Makefile's DOC_FILES in their listed order. Link text generally follows the headers used by the linked document. Informative stuff (for image and implementation authors) is indented under the README (although I'm not sure there's consensus on whether media-types.md is normative or informative).

@wking
Copy link
Contributor Author

wking commented Sep 14, 2016

Spun off from this discussion.

@philips
Copy link
Contributor

philips commented Sep 14, 2016

LGTM.

Approved with PullApprove

@vbatts
Copy link
Member

vbatts commented Sep 15, 2016

LGTM

Approved with PullApprove

@vbatts
Copy link
Member

vbatts commented Sep 15, 2016

doh. rebase plz

Linking the files from Makefile's DOC_FILES in their listed order.
Link text generally follows the headers used by the linked document.
Informative stuff (for image and implementation authors) is indented
under the README (although I'm not sure there's consensus on whether
media-types.md is normative or informative [1]).

[1]: opencontainers#304 (comment)
     Subject: manifest: List media types supported by descriptor references

Signed-off-by: W. Trevor King <[email protected]>
@wking
Copy link
Contributor Author

wking commented Sep 15, 2016

On Thu, Sep 15, 2016 at 07:22:35AM -0700, Vincent Batts wrote:

doh. rebase plz

Rebased onto master with 925594 → 5d91f6b.

@vbatts
Copy link
Member

vbatts commented Sep 15, 2016

LGTM

Approved with PullApprove

@jonboulle
Copy link
Contributor

jonboulle commented Sep 16, 2016

lgtm

Approved with PullApprove

@jonboulle jonboulle merged commit 287772a into opencontainers:master Sep 16, 2016
@wking wking deleted the table-of-contents branch September 21, 2016 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants